Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: deuling@de.ibm.com (Markus Deuling)
Cc: gdb-patches@sourceware.org (GDB Patches),
	        brobecker@adacore.com (Joel Brobecker),
	        drow@false.org (Daniel Jacobowitz),
	        maxim@tensilica.com (Maxim Grigoriev)
Subject: Re: [rfc] [0/8] Get rid of current_gdbarch
Date: Tue, 09 Oct 2007 18:34:00 -0000	[thread overview]
Message-ID: <200710091822.l99IMjMk017593@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <470B6819.1070903@de.ibm.com> from "Markus Deuling" at Oct 09, 2007 01:38:01 PM

Markus Deuling wrote:

> this is the next series of 8 mostly mechnical patches to get rid of of some trivial to replace occurences of current_gdbarch. 

I've checked in all of those except:

- the xtensa-tdep.c patch (to give Maxim a chance to comment), and
- the stack.c patch, because of this:

@@ -1854,10 +1856,11 @@ If you continue, the return value that y
   if (return_value != NULL)
     {
       struct type *return_type = value_type (return_value);
-      gdb_assert (gdbarch_return_value (current_gdbarch, return_type,
+      gdb_assert (gdbarch_return_value (get_frame_arch (get_current_frame ()),
+					return_type,
 					NULL, NULL, NULL)
 		  == RETURN_VALUE_REGISTER_CONVENTION);
-      gdbarch_return_value (current_gdbarch, return_type,
+      gdbarch_return_value (get_frame_arch (get_current_frame ()), return_type,
 			    get_current_regcache (), NULL /*read*/,
 			    value_contents (return_value) /*write*/);
     }

At this point, there's no need to involve get_current_frame.  The
routine operates on the current regcache, and should simply consult
its architecture.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2007-10-09 18:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-09 11:39 Markus Deuling
2007-10-09 18:34 ` Ulrich Weigand [this message]
2007-10-09 18:45   ` Daniel Jacobowitz
2007-10-09 18:54     ` Ulrich Weigand
2007-10-09 19:50   ` Maxim Grigoriev
2007-10-09 19:59     ` Ulrich Weigand
2007-10-10  5:14       ` Markus Deuling
2007-10-10  8:09   ` Markus Deuling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710091822.l99IMjMk017593@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=brobecker@adacore.com \
    --cc=deuling@de.ibm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=maxim@tensilica.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox