From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: drow@false.org (Daniel Jacobowitz)
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Multi-threaded watchpoints, GNU/Linux native bits
Date: Tue, 02 Oct 2007 16:42:00 -0000 [thread overview]
Message-ID: <200710021642.l92GgeKr021244@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20070916185734.GA24815@caradoc.them.org> from "Daniel Jacobowitz" at Sep 16, 2007 02:57:34 PM
Daniel Jacobowitz wrote:
> - last_stopped_data_address = (uintptr_t) siginfo.si_addr;
> + *addr_p = (CORE_ADDR) siginfo_p->si_addr;
This causes a warning (and build break) when pointers are 32-bit
but CORE_ADDR is 64-bit. Fixed by adding back a cast to uintptr_t.
Committed to mainline.
Bye,
Ulrich
ChangeLog:
* ppc-linux-nat.c (ppc_linux_stopped_data_address): Cast
pointer to uintptr_t before casting to CORE_ADDR.
Index: gdb/ppc-linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/ppc-linux-nat.c,v
retrieving revision 1.71
diff -c -p -r1.71 ppc-linux-nat.c
*** gdb/ppc-linux-nat.c 1 Oct 2007 00:22:50 -0000 1.71
--- gdb/ppc-linux-nat.c 2 Oct 2007 16:37:19 -0000
*************** ppc_linux_stopped_data_address (struct t
*** 869,875 ****
|| (siginfo_p->si_code & 0xffff) != 0x0004 /* TRAP_HWBKPT */)
return 0;
! *addr_p = (CORE_ADDR) siginfo_p->si_addr;
return 1;
}
--- 869,875 ----
|| (siginfo_p->si_code & 0xffff) != 0x0004 /* TRAP_HWBKPT */)
return 0;
! *addr_p = (CORE_ADDR) (uintptr_t) siginfo_p->si_addr;
return 1;
}
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2007-10-02 16:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-16 18:57 Daniel Jacobowitz
2007-09-17 14:15 ` Luis Machado
2007-10-01 0:23 ` Daniel Jacobowitz
2007-10-02 16:42 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710021642.l92GgeKr021244@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox