From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31322 invoked by alias); 2 Oct 2007 16:42:52 -0000 Received: (qmail 31313 invoked by uid 22791); 2 Oct 2007 16:42:51 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate7.de.ibm.com (HELO mtagate7.de.ibm.com) (195.212.29.156) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 02 Oct 2007 16:42:45 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate7.de.ibm.com (8.13.8/8.13.8) with ESMTP id l92GgfHh226502 for ; Tue, 2 Oct 2007 16:42:41 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l92GgfHQ1941506 for ; Tue, 2 Oct 2007 18:42:41 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l92GgeOj021247 for ; Tue, 2 Oct 2007 18:42:41 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l92GgeKr021244; Tue, 2 Oct 2007 18:42:40 +0200 Message-Id: <200710021642.l92GgeKr021244@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 2 Oct 2007 18:42:40 +0200 Subject: Re: [rfc] Multi-threaded watchpoints, GNU/Linux native bits To: drow@false.org (Daniel Jacobowitz) Date: Tue, 02 Oct 2007 16:42:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20070916185734.GA24815@caradoc.them.org> from "Daniel Jacobowitz" at Sep 16, 2007 02:57:34 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00021.txt.bz2 Daniel Jacobowitz wrote: > - last_stopped_data_address = (uintptr_t) siginfo.si_addr; > + *addr_p = (CORE_ADDR) siginfo_p->si_addr; This causes a warning (and build break) when pointers are 32-bit but CORE_ADDR is 64-bit. Fixed by adding back a cast to uintptr_t. Committed to mainline. Bye, Ulrich ChangeLog: * ppc-linux-nat.c (ppc_linux_stopped_data_address): Cast pointer to uintptr_t before casting to CORE_ADDR. Index: gdb/ppc-linux-nat.c =================================================================== RCS file: /cvs/src/src/gdb/ppc-linux-nat.c,v retrieving revision 1.71 diff -c -p -r1.71 ppc-linux-nat.c *** gdb/ppc-linux-nat.c 1 Oct 2007 00:22:50 -0000 1.71 --- gdb/ppc-linux-nat.c 2 Oct 2007 16:37:19 -0000 *************** ppc_linux_stopped_data_address (struct t *** 869,875 **** || (siginfo_p->si_code & 0xffff) != 0x0004 /* TRAP_HWBKPT */) return 0; ! *addr_p = (CORE_ADDR) siginfo_p->si_addr; return 1; } --- 869,875 ---- || (siginfo_p->si_code & 0xffff) != 0x0004 /* TRAP_HWBKPT */) return 0; ! *addr_p = (CORE_ADDR) (uintptr_t) siginfo_p->si_addr; return 1; } -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com