From: Luis Machado <luisgpm@linux.vnet.ibm.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] Multi-threaded watchpoints, GNU/Linux native bits
Date: Mon, 17 Sep 2007 14:15:00 -0000 [thread overview]
Message-ID: <1190038504.4651.30.camel@localhost> (raw)
In-Reply-To: <20070916185734.GA24815@caradoc.them.org>
> static int
> -ppc_linux_stopped_by_watchpoint (void)
> +ppc_linux_stopped_data_address (struct target_ops *target, CORE_ADDR *addr_p)
> {
> - int tid;
> - struct siginfo siginfo;
> - ptid_t ptid = inferior_ptid;
> + struct siginfo *siginfo_p;
> CORE_ADDR *addr_p;
>
> - tid = TIDGET(ptid);
> - if (tid == 0)
Quick comment:
"CORE_ADDR *addr_p" right below "siginfo_p" should be eliminated since
we're already getting that parameter from the function call.
Regards,
Luis Machado
IBM Linux Technology Center
e-mail: luisgpm@linux.vnet.ibm.com
next prev parent reply other threads:[~2007-09-17 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-16 18:57 Daniel Jacobowitz
2007-09-17 14:15 ` Luis Machado [this message]
2007-10-01 0:23 ` Daniel Jacobowitz
2007-10-02 16:42 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190038504.4651.30.camel@localhost \
--to=luisgpm@linux.vnet.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox