From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-50816-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27865 invoked by alias); 17 Sep 2007 14:15:30 -0000
Received: (qmail 27854 invoked by uid 22791); 17 Sep 2007 14:15:30 -0000
X-Spam-Check-By: sourceware.org
Received: from igw2.br.ibm.com (HELO igw2.br.ibm.com) (32.104.18.25)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Sep 2007 14:15:23 +0000
Received: from mailhub3.br.ibm.com (mailhub3 [9.18.232.110]) 	by igw2.br.ibm.com (Postfix) with ESMTP id BEA4717F512 	for <gdb-patches@sourceware.org>; Mon, 17 Sep 2007 11:13:21 -0300 (BRT)
Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) 	by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l8HEFFfv1060952 	for <gdb-patches@sourceware.org>; Mon, 17 Sep 2007 11:15:16 -0300
Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) 	by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l8HEF9NH015972 	for <gdb-patches@sourceware.org>; Mon, 17 Sep 2007 11:15:13 -0300
Received: from [9.18.238.24] ([9.18.238.24]) 	by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l8HEF5DR015662; 	Mon, 17 Sep 2007 11:15:06 -0300
Subject: Re: [rfc] Multi-threaded watchpoints, GNU/Linux native bits
From: Luis Machado <luisgpm@linux.vnet.ibm.com>
Reply-To: luisgpm@linux.vnet.ibm.com
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20070916185734.GA24815@caradoc.them.org>
References: <20070916185734.GA24815@caradoc.them.org>
Content-Type: text/plain
Date: Mon, 17 Sep 2007 14:15:00 -0000
Message-Id: <1190038504.4651.30.camel@localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.6.1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-09/txt/msg00225.txt.bz2

>  static int
> -ppc_linux_stopped_by_watchpoint (void)
> +ppc_linux_stopped_data_address (struct target_ops *target, CORE_ADDR *addr_p)
>  {
> -  int tid;
> -  struct siginfo siginfo;
> -  ptid_t ptid = inferior_ptid;
> +  struct siginfo *siginfo_p;
>    CORE_ADDR *addr_p;
> 
> -  tid = TIDGET(ptid);
> -  if (tid == 0)

Quick comment:

"CORE_ADDR *addr_p" right below "siginfo_p" should be eliminated since
we're already getting that parameter from the function call.

Regards,
 
Luis Machado
IBM Linux Technology Center
e-mail: luisgpm@linux.vnet.ibm.com