Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [rfc] Remove some empty lines from the linetable
Date: Mon, 01 Oct 2007 20:59:00 -0000	[thread overview]
Message-ID: <20071001205920.GA30948@caradoc.them.org> (raw)
In-Reply-To: <20071001204943.GB4305@adacore.com>

On Mon, Oct 01, 2007 at 01:49:43PM -0700, Joel Brobecker wrote:
> There is one thing I am not sure about, though. In your patch,
> you still add the end-of-sequence marker. So you eliminate the
> empty line 58, but keep it's associated line 0 entry. I guess
> we have to in the following case:
> 
>   line 57 @ 0x1234
>   line 58 @ 0x1240
>   line 0  @ 0x1240
> 
> We need this because otherwise we'd record the wrong end-address
> for line 57.

Right.  Sometimes we end up with two zeros in a row this way, which is
useless and ugly but harmless.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-10-01 20:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-01 15:48 Daniel Jacobowitz
2007-10-01 20:49 ` Joel Brobecker
2007-10-01 20:59   ` Daniel Jacobowitz [this message]
2007-10-11 18:04 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071001205920.GA30948@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox