From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1327 invoked by alias); 1 Oct 2007 20:59:27 -0000 Received: (qmail 1319 invoked by uid 22791); 1 Oct 2007 20:59:26 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 01 Oct 2007 20:59:23 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id BA8959810B for ; Mon, 1 Oct 2007 20:59:21 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 9D1559810A for ; Mon, 1 Oct 2007 20:59:21 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IcSMK-00083T-Bu for gdb-patches@sourceware.org; Mon, 01 Oct 2007 16:59:20 -0400 Date: Mon, 01 Oct 2007 20:59:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [rfc] Remove some empty lines from the linetable Message-ID: <20071001205920.GA30948@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20071001154757.GC12927@caradoc.them.org> <20071001204943.GB4305@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071001204943.GB4305@adacore.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00009.txt.bz2 On Mon, Oct 01, 2007 at 01:49:43PM -0700, Joel Brobecker wrote: > There is one thing I am not sure about, though. In your patch, > you still add the end-of-sequence marker. So you eliminate the > empty line 58, but keep it's associated line 0 entry. I guess > we have to in the following case: > > line 57 @ 0x1234 > line 58 @ 0x1240 > line 0 @ 0x1240 > > We need this because otherwise we'd record the wrong end-address > for line 57. Right. Sometimes we end up with two zeros in a row this way, which is useless and ugly but harmless. -- Daniel Jacobowitz CodeSourcery