From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [rfc] Remove some empty lines from the linetable
Date: Mon, 01 Oct 2007 20:49:00 -0000 [thread overview]
Message-ID: <20071001204943.GB4305@adacore.com> (raw)
In-Reply-To: <20071001154757.GC12927@caradoc.them.org>
> I thought about sorting groups of consecutive lines instead of
> individual lines. That's tricky and a wasteful of memory, though, if
> this simpler solution works: just delete such troublesome cases in
> record_line.
I think it makes sense.
> 2007-10-01 Daniel Jacobowitz <dan@codesourcery.com>
>
> * buildsym.c (record_line): Remove empty lines followed by
> end-of-sequence markers.
There is one thing I am not sure about, though. In your patch,
you still add the end-of-sequence marker. So you eliminate the
empty line 58, but keep it's associated line 0 entry. I guess
we have to in the following case:
line 57 @ 0x1234
line 58 @ 0x1240
line 0 @ 0x1240
We need this because otherwise we'd record the wrong end-address
for line 57.
So I agree the patch makes sense, and I prefer it to be independent
of the debugging info.
--
Joel
next prev parent reply other threads:[~2007-10-01 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 15:48 Daniel Jacobowitz
2007-10-01 20:49 ` Joel Brobecker [this message]
2007-10-01 20:59 ` Daniel Jacobowitz
2007-10-11 18:04 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071001204943.GB4305@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox