From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org, gpc@gnu.de
Subject: Re: [RFC] Handle GPC specific name for main function
Date: Wed, 26 Sep 2007 19:50:00 -0000 [thread overview]
Message-ID: <20070926194950.GA21242@adacore.com> (raw)
In-Reply-To: <001501c80074$ff05ddc0$fd119940$@u-strasbg.fr>
> > /* The name of the symbol that GPC uses as the name of the main
> > subprogram (since version ...). */
>
> Here, I really need feedback from GPC developers!
This makes sense. I thought you had already consulted with the GPC
developers...
> > You also need to update Makefile.in, since you added a dependency.
>
> Funny, while trying to add this, I noticed that
> ${ada_lang_h} was twice in the dependency list, so
> I just replaced the second one with ${p_lang_h}
Excellent, thanks for catching and fixing this.
> > With these adjustments in, your patch is pre-approved (but please
> > remember to give it a round of testing, just in cases).
>
> Thanks, but my problem is that I am unable to run the testsuite,
> and anyhow gdb.pascal is not yet in CVS,
> and its mainly there where I expect a change.
I am mostly concerned about the effect on the other languages.
I just want to make sure that the rest of the testsuite results
stay unchanged. If you don't have access to a machine where you
can run the testsuite, then let me know, and I'll give it a quick
run on one of our fast machines for you. Your change looks relatively
straightforward, but it never hurts to be cautious.
--
Joel
next prev parent reply other threads:[~2007-09-26 19:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 14:40 Pierre Muller
2007-09-26 15:03 ` Eli Zaretskii
2007-09-26 15:32 ` Pierre Muller
2007-09-26 17:48 ` Eli Zaretskii
2007-09-26 17:58 ` Joel Brobecker
2007-09-26 19:39 ` Pierre Muller
2007-09-26 19:50 ` Joel Brobecker [this message]
2007-09-26 22:06 ` Pierre Muller
2007-09-26 22:39 ` [RFC-2] " Pierre Muller
2007-09-27 6:03 ` Joel Brobecker
2007-09-27 7:29 ` [RFC-3] " Pierre Muller
[not found] ` <46FB5E2C.6080606@microbizz.nl>
[not found] ` <46FB5F76.9050501@microbizz.nl>
2007-09-27 7:57 ` Pierre Muller
2007-09-27 12:11 ` Daniel Jacobowitz
2007-09-27 12:35 ` Pierre Muller
2007-09-27 12:40 ` 'Daniel Jacobowitz'
2007-09-27 16:20 ` Joel Brobecker
2007-09-27 16:32 ` Joel Brobecker
2007-09-27 21:36 ` Pierre Muller
2007-09-28 18:31 ` Joel Brobecker
2007-09-27 8:02 ` Pierre Muller
2007-09-27 13:01 ` Waldek Hebisch
2007-09-27 7:20 ` [RFC-2] " Eli Zaretskii
2007-09-27 1:58 ` [RFC] " Waldek Hebisch
2007-09-27 5:52 ` Joel Brobecker
2007-09-27 17:17 ` Thiago Jung Bauermann
2007-09-27 19:50 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070926194950.GA21242@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gpc@gnu.de \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox