Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>,
		'Adriaan van Os' <gpc@microbizz.nl>,
	gpc@gnu.de, 	gdb-patches@sourceware.org
Subject: Re: [RFC-3] Handle GPC specific name for main function
Date: Thu, 27 Sep 2007 16:32:00 -0000	[thread overview]
Message-ID: <20070927163217.GD3787@adacore.com> (raw)
In-Reply-To: <20070927162039.GC3787@adacore.com>

> > >   Anyhow, this can only lead to failures to detect
> > > GPC properly. I think that the patch, even if it might
> > > miss more cases, is also much more safe this way, because
> > > we only use (_p_MO__main_program or pascal_main_program)
> > > as start command breakpoint if '_p_initialize' was also found.
> > 
> > Seems reasonable to me.  Joel?
> 
> Seems reasonable to me too.

Actually, is it really reducing the potential for false positives?

Let's recap: _p_initialize is defined when the Pascal runtime is linked
in. _p_MO__main_program is sufficiently unlikely that such a symbol name
should be a Pascal procedure pretty much all the time. So I'm wondering
whether checking for _p_initialize will help reducing the number of
false positive at all (because would _p_MO__main_program => _p_initialize).
So is this patch really better than the previous one?

-- 
Joel


  reply	other threads:[~2007-09-27 16:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26 14:40 [RFC] " Pierre Muller
2007-09-26 15:03 ` Eli Zaretskii
2007-09-26 15:32   ` Pierre Muller
2007-09-26 17:48     ` Eli Zaretskii
2007-09-26 17:58 ` Joel Brobecker
2007-09-26 19:39   ` Pierre Muller
2007-09-26 19:50     ` Joel Brobecker
2007-09-26 22:06       ` Pierre Muller
2007-09-26 22:39         ` [RFC-2] " Pierre Muller
2007-09-27  6:03           ` Joel Brobecker
2007-09-27  7:29             ` [RFC-3] " Pierre Muller
     [not found]               ` <46FB5E2C.6080606@microbizz.nl>
     [not found]                 ` <46FB5F76.9050501@microbizz.nl>
2007-09-27  7:57                   ` Pierre Muller
2007-09-27 12:11                     ` Daniel Jacobowitz
2007-09-27 12:35                       ` Pierre Muller
2007-09-27 12:40                         ` 'Daniel Jacobowitz'
2007-09-27 16:20                           ` Joel Brobecker
2007-09-27 16:32                             ` Joel Brobecker [this message]
2007-09-27 21:36                               ` Pierre Muller
2007-09-28 18:31                                 ` Joel Brobecker
2007-09-27  8:02                 ` Pierre Muller
2007-09-27 13:01                   ` Waldek Hebisch
2007-09-27  7:20           ` [RFC-2] " Eli Zaretskii
2007-09-27  1:58 ` [RFC] " Waldek Hebisch
2007-09-27  5:52   ` Joel Brobecker
2007-09-27 17:17     ` Thiago Jung Bauermann
2007-09-27 19:50       ` Jim Blandy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070927163217.GD3787@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gpc@gnu.de \
    --cc=gpc@microbizz.nl \
    --cc=muller@ics.u-strasbg.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox