From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13757 invoked by alias); 26 Sep 2007 19:50:00 -0000 Received: (qmail 13749 invoked by uid 22791); 26 Sep 2007 19:49:59 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 26 Sep 2007 19:49:55 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 626552AA9BC; Wed, 26 Sep 2007 15:49:53 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id wlErt6LFySzQ; Wed, 26 Sep 2007 15:49:53 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1862D2AA439; Wed, 26 Sep 2007 15:49:53 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 7AD6AE7B58; Wed, 26 Sep 2007 12:49:50 -0700 (PDT) Date: Wed, 26 Sep 2007 19:50:00 -0000 From: Joel Brobecker To: Pierre Muller Cc: gdb-patches@sourceware.org, gpc@gnu.de Subject: Re: [RFC] Handle GPC specific name for main function Message-ID: <20070926194950.GA21242@adacore.com> References: <003901c8004b$2f9a55d0$8ecf0170$@u-strasbg.fr> <20070926175805.GA6208@adacore.com> <001501c80074$ff05ddc0$fd119940$@u-strasbg.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <001501c80074$ff05ddc0$fd119940$@u-strasbg.fr> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00387.txt.bz2 > > /* The name of the symbol that GPC uses as the name of the main > > subprogram (since version ...). */ > > Here, I really need feedback from GPC developers! This makes sense. I thought you had already consulted with the GPC developers... > > You also need to update Makefile.in, since you added a dependency. > > Funny, while trying to add this, I noticed that > ${ada_lang_h} was twice in the dependency list, so > I just replaced the second one with ${p_lang_h} Excellent, thanks for catching and fixing this. > > With these adjustments in, your patch is pre-approved (but please > > remember to give it a round of testing, just in cases). > > Thanks, but my problem is that I am unable to run the testsuite, > and anyhow gdb.pascal is not yet in CVS, > and its mainly there where I expect a change. I am mostly concerned about the effect on the other languages. I just want to make sure that the rest of the testsuite results stay unchanged. If you don't have access to a machine where you can run the testsuite, then let me know, and I'll give it a quick run on one of our fast machines for you. Your change looks relatively straightforward, but it never hurts to be cautious. -- Joel