Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: drow@false.org (Daniel Jacobowitz)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch, rfc, rft] Multi-threaded single-step vs. breakpoint         problems (prepare_to_proceed)
Date: Mon, 10 Sep 2007 18:53:00 -0000	[thread overview]
Message-ID: <200709101853.l8AIrMWR005070@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20070903201609.GA26767@caradoc.them.org> from "Daniel Jacobowitz" at Sep 03, 2007 04:16:09 PM

Daniel Jacobowitz wrote:
> On Fri, Aug 03, 2007 at 06:54:34PM +0200, Ulrich Weigand wrote:
> > ChangeLog:
> > 
> > 	* infrun.c (stepping_past_breakpoint): New global variable.
> > 	(stepping_past_breakpoint_ptid): Likewise.
> > 	(prepare_to_proceed): Add STEP parameter.  Do not check for Ctrl-C.
> > 	Only switch threads if we need to single-step over a breakpoint hit
> > 	in the previously selected thread.  If stepping, remember previous
> > 	thread to switch back to in STEPPING_PAST_BREAKPOINT[_PTID].  Call
> > 	switch_to_thread instead of copying its contents.
> > 	(proceed): Pass STEP to prepare_to_proceed.  Always set ONEPROC if
> > 	prepare_to_proceed returns true.
> > 	(init_wait_for_inferior): Reset STEPPING_PAST_BREAKPOINT.
> > 	(context_switch): Call switch_to_thread.
> > 	(handle_inferior_event): Switch back to previous thread if requested
> > 	in STEPPING_PAST_BREAKPOINT[_PTID] by prepare_to_proceed.
> > 	* gdbthread.h (switch_to_thread): Add prototype.
> > 	* thread.c (switch_to_thread): Make global.
> 
> No one else has commented on this patch in the last month; I think you
> should probably commit it (though you may wish to wait until after
> the release branch - I've no preference).

Thanks for reminding me of this.  I've checked this in now.  That means
it'll not be part of the release branch -- I think that's OK.

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


      reply	other threads:[~2007-09-10 18:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-01 19:52 Ulrich Weigand
2007-08-02 19:42 ` Daniel Jacobowitz
2007-08-03 16:54   ` Ulrich Weigand
2007-09-03 20:16     ` Daniel Jacobowitz
2007-09-10 18:53       ` Ulrich Weigand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709101853.l8AIrMWR005070@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox