From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12803 invoked by alias); 10 Sep 2007 18:53:36 -0000 Received: (qmail 12795 invoked by uid 22791); 10 Sep 2007 18:53:35 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 10 Sep 2007 18:53:25 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l8AIrMqc1666576 for ; Mon, 10 Sep 2007 18:53:22 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l8AIrMDj2277464 for ; Mon, 10 Sep 2007 20:53:22 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l8AIrMRp005073 for ; Mon, 10 Sep 2007 20:53:22 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l8AIrMWR005070; Mon, 10 Sep 2007 20:53:22 +0200 Message-Id: <200709101853.l8AIrMWR005070@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 10 Sep 2007 20:53:22 +0200 Subject: Re: [patch, rfc, rft] Multi-threaded single-step vs. breakpoint problems (prepare_to_proceed) To: drow@false.org (Daniel Jacobowitz) Date: Mon, 10 Sep 2007 18:53:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20070903201609.GA26767@caradoc.them.org> from "Daniel Jacobowitz" at Sep 03, 2007 04:16:09 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00144.txt.bz2 Daniel Jacobowitz wrote: > On Fri, Aug 03, 2007 at 06:54:34PM +0200, Ulrich Weigand wrote: > > ChangeLog: > > > > * infrun.c (stepping_past_breakpoint): New global variable. > > (stepping_past_breakpoint_ptid): Likewise. > > (prepare_to_proceed): Add STEP parameter. Do not check for Ctrl-C. > > Only switch threads if we need to single-step over a breakpoint hit > > in the previously selected thread. If stepping, remember previous > > thread to switch back to in STEPPING_PAST_BREAKPOINT[_PTID]. Call > > switch_to_thread instead of copying its contents. > > (proceed): Pass STEP to prepare_to_proceed. Always set ONEPROC if > > prepare_to_proceed returns true. > > (init_wait_for_inferior): Reset STEPPING_PAST_BREAKPOINT. > > (context_switch): Call switch_to_thread. > > (handle_inferior_event): Switch back to previous thread if requested > > in STEPPING_PAST_BREAKPOINT[_PTID] by prepare_to_proceed. > > * gdbthread.h (switch_to_thread): Add prototype. > > * thread.c (switch_to_thread): Make global. > > No one else has commented on this patch in the last month; I think you > should probably commit it (though you may wish to wait until after > the release branch - I've no preference). Thanks for reminding me of this. I've checked this in now. That means it'll not be part of the release branch -- I think that's OK. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com