From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch, rfc, rft] Multi-threaded single-step vs. breakpoint problems (prepare_to_proceed)
Date: Thu, 02 Aug 2007 19:42:00 -0000 [thread overview]
Message-ID: <20070802194220.GB6563@caradoc.them.org> (raw)
In-Reply-To: <200708011952.l71JqO6e015264@d12av02.megacenter.de.ibm.com>
On Wed, Aug 01, 2007 at 09:52:21PM +0200, Ulrich Weigand wrote:
> The main changes to prepare_to_proceed are do only ever switch threads
> if we stopped due to hitting a breakpoint which is still set, and the
> user switched threads in the meantime. If we're also about to single-
> step, we remember which thread we were supposed to step, and switch
> back to it in handle_inferior_event after we're stepped past that
> breakpoint.
I've no objection and the patch seems fine to me. I wonder what
happens if the other thread hit a watchpoint, or some other
non-breakpoint event, though; on some platforms watchpoints must be
stepped past similarly.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-08-02 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 19:52 Ulrich Weigand
2007-08-02 19:42 ` Daniel Jacobowitz [this message]
2007-08-03 16:54 ` Ulrich Weigand
2007-09-03 20:16 ` Daniel Jacobowitz
2007-09-10 18:53 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070802194220.GB6563@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox