Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Modra <amodra@bigpond.net.au>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: powerpc-linux biarch corefile support
Date: Wed, 29 Aug 2007 08:28:00 -0000	[thread overview]
Message-ID: <20070829082759.GB25275@bubble.grove.modra.org> (raw)
In-Reply-To: <20070829072556.GA25275@bubble.grove.modra.org>

On Wed, Aug 29, 2007 at 04:55:56PM +0930, Alan Modra wrote:
> On Wed, Aug 29, 2007 at 01:03:05AM +0200, Ulrich Weigand wrote:
> > Also, you missed setting the gpr_size field in a couple of cases:
> > rs6000-aix-tdep.c:rs6000_aix32_reg_offsets
> > rs6000-aix-tdep.c:rs6000_aix64_reg_offsets
> > ppcobsd-nat.c:ppcobsd_reg_offsets
> 
> Oops, shame on me.  I'll fix that.

On looking at rs6000_aix64_reg_offsets, I noticed that xer_offset is
not a multiple of 8.  Apparently, AIX uses a 32-bit field for cr, xer,
and fpscr.  So it looks like I can't use gpr_size for any of these
registers in ppc_{supply,collect}_gregset.  Mind you, aix 64-bit gdb
is broken anyway due to these functions assuming the gprs were
32-bit.

-- 
Alan Modra
Australia Development Lab, IBM


  reply	other threads:[~2007-08-29  8:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-22 16:43 Alan Modra
2007-01-22 17:12 ` Mark Kettenis
2007-01-23  6:57   ` Alan Modra
2007-02-08 14:40     ` Daniel Jacobowitz
2007-04-28 16:24     ` Ulrich Weigand
2007-08-25  1:23       ` Alan Modra
2007-08-28 23:03         ` Ulrich Weigand
2007-08-29  7:26           ` Alan Modra
2007-08-29  8:28             ` Alan Modra [this message]
     [not found]               ` <OFA57C40FB.23E13286-ON42257346.004A0E7C-42257346.004A56D1@de.ibm.com>
2007-08-30 12:14                 ` Alan Modra
2007-08-30 12:50                   ` Ulrich Weigand
2007-08-30 13:14                     ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070829082759.GB25275@bubble.grove.modra.org \
    --to=amodra@bigpond.net.au \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox