From: Daniel Jacobowitz <drow@false.org>
To: Alan Modra <amodra@bigpond.net.au>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: powerpc-linux biarch corefile support
Date: Thu, 08 Feb 2007 14:40:00 -0000 [thread overview]
Message-ID: <20070208144017.GD6861@nevyn.them.org> (raw)
In-Reply-To: <20070123065726.GG8686@bubble.grove.modra.org>
On Tue, Jan 23, 2007 at 05:27:26PM +1030, Alan Modra wrote:
> Yes, it is for zero extending, and also for initializing unused
> fields. Random values in unused fields (eg. orig_gpr3) look odd in
> core dumps. I could cure that particular problem by clearing the
> buffer in linux-nat.c:linux_nat_do_thread_registers, but that doesn't
> help ps_lgetregs.
Note, we use this very rarely now - libthread_db may call it internally
to get at the thread pointer, but we no longer use it to get at
registers for our own purposes.
> OK, and thanks for the review. How does this look?
FWIW, it looks fine to me, but it's hard to read a complete rewrite.
Mark, did you want to take a look at this revised patch?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-02-08 14:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-22 16:43 Alan Modra
2007-01-22 17:12 ` Mark Kettenis
2007-01-23 6:57 ` Alan Modra
2007-02-08 14:40 ` Daniel Jacobowitz [this message]
2007-04-28 16:24 ` Ulrich Weigand
2007-08-25 1:23 ` Alan Modra
2007-08-28 23:03 ` Ulrich Weigand
2007-08-29 7:26 ` Alan Modra
2007-08-29 8:28 ` Alan Modra
[not found] ` <OFA57C40FB.23E13286-ON42257346.004A0E7C-42257346.004A56D1@de.ibm.com>
2007-08-30 12:14 ` Alan Modra
2007-08-30 12:50 ` Ulrich Weigand
2007-08-30 13:14 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070208144017.GD6861@nevyn.them.org \
--to=drow@false.org \
--cc=amodra@bigpond.net.au \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox