From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6216 invoked by alias); 8 Feb 2007 14:40:30 -0000 Received: (qmail 6208 invoked by uid 22791); 8 Feb 2007 14:40:30 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 08 Feb 2007 14:40:24 +0000 Received: from drow by nevyn.them.org with local (Exim 4.63) (envelope-from ) id 1HFARd-0001zW-Hn; Thu, 08 Feb 2007 09:40:17 -0500 Date: Thu, 08 Feb 2007 14:40:00 -0000 From: Daniel Jacobowitz To: Alan Modra Cc: Mark Kettenis , gdb-patches@sourceware.org Subject: Re: powerpc-linux biarch corefile support Message-ID: <20070208144017.GD6861@nevyn.them.org> Mail-Followup-To: Alan Modra , Mark Kettenis , gdb-patches@sourceware.org References: <20070122164308.GF8686@bubble.grove.modra.org> <200701221711.l0MHBr7d028668@brahms.sibelius.xs4all.nl> <20070123065726.GG8686@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070123065726.GG8686@bubble.grove.modra.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00076.txt.bz2 On Tue, Jan 23, 2007 at 05:27:26PM +1030, Alan Modra wrote: > Yes, it is for zero extending, and also for initializing unused > fields. Random values in unused fields (eg. orig_gpr3) look odd in > core dumps. I could cure that particular problem by clearing the > buffer in linux-nat.c:linux_nat_do_thread_registers, but that doesn't > help ps_lgetregs. Note, we use this very rarely now - libthread_db may call it internally to get at the thread pointer, but we no longer use it to get at registers for our own purposes. > OK, and thanks for the review. How does this look? FWIW, it looks fine to me, but it's hard to read a complete rewrite. Mark, did you want to take a look at this revised patch? -- Daniel Jacobowitz CodeSourcery