From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30279 invoked by alias); 29 Aug 2007 08:28:10 -0000 Received: (qmail 30152 invoked by uid 22791); 29 Aug 2007 08:28:08 -0000 X-Spam-Check-By: sourceware.org Received: from omta05ps.mx.bigpond.com (HELO omta05ps.mx.bigpond.com) (144.140.83.195) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 29 Aug 2007 08:28:03 +0000 Received: from oaamta05ps.mx.bigpond.com ([58.174.192.2]) by omta05ps.mx.bigpond.com with ESMTP id <20070829082759.VAMO154.omta05ps.mx.bigpond.com@oaamta05ps.mx.bigpond.com> for ; Wed, 29 Aug 2007 08:27:59 +0000 Received: from bubble.grove.modra.org ([58.174.192.2]) by oaamta05ps.mx.bigpond.com with ESMTP id <20070829082759.ISXB23432.oaamta05ps.mx.bigpond.com@bubble.grove.modra.org>; Wed, 29 Aug 2007 08:27:59 +0000 Received: by bubble.grove.modra.org (Postfix, from userid 500) id 3A5A7309172; Wed, 29 Aug 2007 17:57:59 +0930 (CST) Date: Wed, 29 Aug 2007 08:28:00 -0000 From: Alan Modra To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: powerpc-linux biarch corefile support Message-ID: <20070829082759.GB25275@bubble.grove.modra.org> References: <20070825012327.GG31717@bubble.grove.modra.org> <200708282303.l7SN35rM004362@d12av02.megacenter.de.ibm.com> <20070829072556.GA25275@bubble.grove.modra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070829072556.GA25275@bubble.grove.modra.org> User-Agent: Mutt/1.5.9i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00510.txt.bz2 On Wed, Aug 29, 2007 at 04:55:56PM +0930, Alan Modra wrote: > On Wed, Aug 29, 2007 at 01:03:05AM +0200, Ulrich Weigand wrote: > > Also, you missed setting the gpr_size field in a couple of cases: > > rs6000-aix-tdep.c:rs6000_aix32_reg_offsets > > rs6000-aix-tdep.c:rs6000_aix64_reg_offsets > > ppcobsd-nat.c:ppcobsd_reg_offsets > > Oops, shame on me. I'll fix that. On looking at rs6000_aix64_reg_offsets, I noticed that xer_offset is not a multiple of 8. Apparently, AIX uses a 32-bit field for cr, xer, and fpscr. So it looks like I can't use gpr_size for any of these registers in ppc_{supply,collect}_gregset. Mind you, aix 64-bit gdb is broken anyway due to these functions assuming the gprs were 32-bit. -- Alan Modra Australia Development Lab, IBM