From: Bob Rossi <bob_rossi@cox.net>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: msnyder@sonic.net, Daniel Jacobowitz <drow@false.org>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] dead code in mi-interp
Date: Fri, 10 Aug 2007 11:22:00 -0000 [thread overview]
Message-ID: <20070810112244.GX21125@cox.net> (raw)
In-Reply-To: <18107.58066.160793.367189@kahikatea.snap.net.nz>
On Fri, Aug 10, 2007 at 04:00:18PM +1200, Nick Roberts wrote:
> > > It may be that it just wasn't hooked up because the asynchronous stuff was
> > > never completed. Once GDB can work asynchronously then it could be
> > > removed, if not needed. Presumably "no side effects" also means "can do
> > > no harm".
> >
> > Well, it can always be recovered from the CVS repository if it is
> > needed. Personally I'd rathern not have dead code in there just
> > because it doesn't do any harm (unles it also has some benefit).
>
> You would only think of recovering it if you already knew it was there. I've
> just explained what I think is the benefit: they provide possible clues about
> an asynchronous implementation.
Even if that was true, the code should be commented out. It really is a
bad thing to have code in the program that is meaningless.
Bob Rossi
next prev parent reply other threads:[~2007-08-10 11:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 22:25 msnyder
2007-08-08 23:24 ` Nick Roberts
2007-08-09 14:47 ` Jim Blandy
2007-08-09 14:57 ` Daniel Jacobowitz
2007-08-09 21:12 ` Nick Roberts
2007-08-09 21:29 ` msnyder
2007-08-09 22:11 ` Bob Rossi
2007-08-10 4:00 ` Nick Roberts
2007-08-10 11:22 ` Bob Rossi [this message]
2007-08-10 21:49 ` msnyder
2007-08-13 22:47 ` ping " msnyder
2007-08-14 11:27 ` Nick Roberts
2007-08-14 19:51 ` msnyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070810112244.GX21125@cox.net \
--to=bob_rossi@cox.net \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@sonic.net \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox