From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: msnyder@sonic.net, gdb-patches@sourceware.org
Subject: Re: [PATCH] dead code in mi-interp
Date: Thu, 09 Aug 2007 14:57:00 -0000 [thread overview]
Message-ID: <20070809145727.GA27809@caradoc.them.org> (raw)
In-Reply-To: <18106.20613.121153.810889@kahikatea.snap.net.nz>
On Thu, Aug 09, 2007 at 11:23:49AM +1200, Nick Roberts wrote:
> > Must have been meant for something, but seems to have no side effects.
>
> There are probably no side effects because currently target_can_async_p ()
> usually returns 0. I hope to add an option to make GDB work asynchronously
> after 6.7 is released. Maybe this still won't be needed but I don't really
> like these kinds of changes. As they say: "If it ain't broke, don't fix it.".
> There must be larger cobwebs to blow away.
That's not what "no side effects" means - the code literally can't
ever have an effect. It creates a string which nothing uses. Why
keep it?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-08-09 14:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 22:25 msnyder
2007-08-08 23:24 ` Nick Roberts
2007-08-09 14:47 ` Jim Blandy
2007-08-09 14:57 ` Daniel Jacobowitz [this message]
2007-08-09 21:12 ` Nick Roberts
2007-08-09 21:29 ` msnyder
2007-08-09 22:11 ` Bob Rossi
2007-08-10 4:00 ` Nick Roberts
2007-08-10 11:22 ` Bob Rossi
2007-08-10 21:49 ` msnyder
2007-08-13 22:47 ` ping " msnyder
2007-08-14 11:27 ` Nick Roberts
2007-08-14 19:51 ` msnyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070809145727.GA27809@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@sonic.net \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox