From: msnyder@sonic.net
To: gdb-patches@sourceware.org
Subject: [PATCH] dead code in mi-interp
Date: Wed, 08 Aug 2007 22:25:00 -0000 [thread overview]
Message-ID: <17268.12.7.175.2.1186611933.squirrel@webmail.sonic.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 72 bytes --]
Must have been meant for something, but seems to have no side effects.
[-- Attachment #2: 287.txt --]
[-- Type: text/plain, Size: 1401 bytes --]
2007-08-08 Michael Snyder <msnyder@access-company.com>
* mi/mi-interp.c (mi_cmd_interpreter_exec): Dead code, dead variable.
Index: mi/mi-interp.c
===================================================================
RCS file: /cvs/src/src/gdb/mi/mi-interp.c,v
retrieving revision 1.20
diff -p -r1.20 mi-interp.c
*** mi/mi-interp.c 28 Apr 2007 21:52:38 -0000 1.20
--- mi/mi-interp.c 8 Aug 2007 22:23:16 -0000
*************** mi_cmd_interpreter_exec (char *command,
*** 218,235 ****
for (i = 1; i < argc; i++)
{
- char *buff = NULL;
- /* Do this in a cleaner way... We want to force execution to be
- asynchronous for commands that run the target. */
- if (target_can_async_p () && (strcmp (argv[0], "console") == 0))
- {
- int len = strlen (argv[i]);
- buff = xmalloc (len + 2);
- memcpy (buff, argv[i], len);
- buff[len] = '&';
- buff[len + 1] = '\0';
- }
-
/* We had to set sync_execution = 0 for the mi (well really for Project
Builder's use of the mi - particularly so interrupting would work.
But for console commands to work, we need to initialize it to 1 -
--- 218,223 ----
*************** mi_cmd_interpreter_exec (char *command,
*** 245,251 ****
break;
}
}
- xfree (buff);
do_exec_error_cleanups (ALL_CLEANUPS);
sync_execution = 0;
}
--- 233,238 ----
next reply other threads:[~2007-08-08 22:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 22:25 msnyder [this message]
2007-08-08 23:24 ` Nick Roberts
2007-08-09 14:47 ` Jim Blandy
2007-08-09 14:57 ` Daniel Jacobowitz
2007-08-09 21:12 ` Nick Roberts
2007-08-09 21:29 ` msnyder
2007-08-09 22:11 ` Bob Rossi
2007-08-10 4:00 ` Nick Roberts
2007-08-10 11:22 ` Bob Rossi
2007-08-10 21:49 ` msnyder
2007-08-13 22:47 ` ping " msnyder
2007-08-14 11:27 ` Nick Roberts
2007-08-14 19:51 ` msnyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17268.12.7.175.2.1186611933.squirrel@webmail.sonic.net \
--to=msnyder@sonic.net \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox