From: Daniel Jacobowitz <drow@false.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [rfc] Wrap addresses in spu-gdb
Date: Wed, 08 Aug 2007 11:42:00 -0000 [thread overview]
Message-ID: <20070808114237.GA27165@caradoc.them.org> (raw)
In-Reply-To: <46B9664D.90907@de.ibm.com>
On Wed, Aug 08, 2007 at 08:44:29AM +0200, Markus Deuling wrote:
> + if (target_has_registers && target_has_stack && target_has_memory
> + /* FIXME: Currently needed for dwarf2_read_address to work. */
> + && type != builtin_type_uint32)
I think that you shouldn't commit a patch with this hack in it.
It looks very fragile.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-08-08 11:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 6:46 Markus Deuling
2007-08-08 11:42 ` Daniel Jacobowitz [this message]
2007-08-08 14:12 ` Ulrich Weigand
2007-08-08 17:10 ` Jim Blandy
2007-08-09 10:39 ` Markus Deuling
2007-08-20 18:42 ` Ulrich Weigand
2007-08-21 9:57 ` Markus Deuling
2007-08-21 11:14 ` Daniel Jacobowitz
2007-08-27 13:01 ` Markus Deuling
2007-08-27 14:32 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070808114237.GA27165@caradoc.them.org \
--to=drow@false.org \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox