From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15451 invoked by alias); 8 Aug 2007 11:42:50 -0000 Received: (qmail 15369 invoked by uid 22791); 8 Aug 2007 11:42:50 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 08 Aug 2007 11:42:41 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 2885F982C5; Wed, 8 Aug 2007 11:42:41 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id D0D59982A4; Wed, 8 Aug 2007 11:42:40 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IIjvx-00074R-Ez; Wed, 08 Aug 2007 07:42:37 -0400 Date: Wed, 08 Aug 2007 11:42:00 -0000 From: Daniel Jacobowitz To: Markus Deuling Cc: GDB Patches , Ulrich Weigand Subject: Re: [rfc] Wrap addresses in spu-gdb Message-ID: <20070808114237.GA27165@caradoc.them.org> Mail-Followup-To: Markus Deuling , GDB Patches , Ulrich Weigand References: <46B9664D.90907@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46B9664D.90907@de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00142.txt.bz2 On Wed, Aug 08, 2007 at 08:44:29AM +0200, Markus Deuling wrote: > + if (target_has_registers && target_has_stack && target_has_memory > + /* FIXME: Currently needed for dwarf2_read_address to work. */ > + && type != builtin_type_uint32) I think that you shouldn't commit a patch with this hack in it. It looks very fragile. -- Daniel Jacobowitz CodeSourcery