From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: [RFA] fix build failure in solib-som.c
Date: Tue, 07 Aug 2007 20:42:00 -0000 [thread overview]
Message-ID: <20070807204529.GA3681@adacore.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 733 bytes --]
Hello,
It looks like a change made a month ago that removed a field called
textsection from the so_list structure is the cause for a build failure
in solib-som.c.
I haven't tested this change, but wouldn't the attached patch make sense?
I don't think we need to keep track of which section is the text section
at this place, since this is done differently somewhere else (in the
current_sos method). So I just removed the associated piece of code.
2007-08-07 Joel Brobecker <brobecker@adacore.com>
* solib-som.c (som_relocate_section_addresses): Stop saving
the $CODE$ section in the so_list structure.
This files compiles fine again after this change is applied.
Would that be OK to apply?
Thanks,
--
Joel
[-- Attachment #2: solib-som.c.diff --]
[-- Type: text/plain, Size: 746 bytes --]
Index: solib-som.c
===================================================================
RCS file: /cvs/src/src/gdb/solib-som.c,v
retrieving revision 1.11
diff -u -p -r1.11 solib-som.c
--- solib-som.c 2 Jul 2007 22:01:09 -0000 1.11
+++ solib-som.c 7 Aug 2007 20:35:36 -0000
@@ -113,13 +113,6 @@ som_relocate_section_addresses (struct s
{
flagword aflag = bfd_get_section_flags(so->abfd, sec->the_bfd_section);
- /* solib.c does something similar, but it only recognizes ".text", SOM calls
- the text section "$CODE$". */
- if (strcmp (sec->the_bfd_section->name, "$CODE$") == 0)
- {
- so->textsection = sec;
- }
-
if (aflag & SEC_CODE)
{
sec->addr += so->lm_info->text_addr - so->lm_info->text_link_addr;
next reply other threads:[~2007-08-07 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 20:42 Joel Brobecker [this message]
2007-08-07 21:47 ` Kevin Buettner
2007-08-07 22:40 ` Joel Brobecker
2007-08-07 23:20 ` Kevin Buettner
2007-08-08 17:41 ` Joel Brobecker
2007-08-08 17:50 ` Kevin Buettner
2007-08-09 16:47 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070807204529.GA3681@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox