From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] fix build failure in solib-som.c
Date: Tue, 07 Aug 2007 21:47:00 -0000 [thread overview]
Message-ID: <20070807144733.26f94534@ironwood.lan> (raw)
In-Reply-To: <20070807204529.GA3681@adacore.com>
On Tue, 7 Aug 2007 13:45:29 -0700
Joel Brobecker <brobecker@adacore.com> wrote:
> It looks like a change made a month ago that removed a field called
> textsection from the so_list structure is the cause for a build failure
> in solib-som.c.
>
> I haven't tested this change, but wouldn't the attached patch make sense?
> I don't think we need to keep track of which section is the text section
> at this place, since this is done differently somewhere else (in the
> current_sos method). So I just removed the associated piece of code.
>
> 2007-08-07 Joel Brobecker <brobecker@adacore.com>
>
> * solib-som.c (som_relocate_section_addresses): Stop saving
> the $CODE$ section in the so_list structure.
>
> This files compiles fine again after this change is applied.
>
> Would that be OK to apply?
I think it would be better to revise the code to set so->addr_low and
so->addr_high to sec->addr and sec->endaddr respectively. You'll also
have to move this block of code to the end of the function.
Kevin
next prev parent reply other threads:[~2007-08-07 21:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 20:42 Joel Brobecker
2007-08-07 21:47 ` Kevin Buettner [this message]
2007-08-07 22:40 ` Joel Brobecker
2007-08-07 23:20 ` Kevin Buettner
2007-08-08 17:41 ` Joel Brobecker
2007-08-08 17:50 ` Kevin Buettner
2007-08-09 16:47 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070807144733.26f94534@ironwood.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox