From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12146 invoked by alias); 7 Aug 2007 21:47:43 -0000 Received: (qmail 11983 invoked by uid 22791); 7 Aug 2007 21:47:41 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 07 Aug 2007 21:47:37 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l77LlZhS019911 for ; Tue, 7 Aug 2007 17:47:35 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l77LlZ06003199 for ; Tue, 7 Aug 2007 17:47:35 -0400 Received: from ironwood.lan (vpn-14-203.rdu.redhat.com [10.11.14.203]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l77LlYsE012019 for ; Tue, 7 Aug 2007 17:47:34 -0400 Date: Tue, 07 Aug 2007 21:47:00 -0000 From: Kevin Buettner To: gdb-patches@sources.redhat.com Subject: Re: [RFA] fix build failure in solib-som.c Message-ID: <20070807144733.26f94534@ironwood.lan> In-Reply-To: <20070807204529.GA3681@adacore.com> References: <20070807204529.GA3681@adacore.com> X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.10.4; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00137.txt.bz2 On Tue, 7 Aug 2007 13:45:29 -0700 Joel Brobecker wrote: > It looks like a change made a month ago that removed a field called > textsection from the so_list structure is the cause for a build failure > in solib-som.c. > > I haven't tested this change, but wouldn't the attached patch make sense? > I don't think we need to keep track of which section is the text section > at this place, since this is done differently somewhere else (in the > current_sos method). So I just removed the associated piece of code. > > 2007-08-07 Joel Brobecker > > * solib-som.c (som_relocate_section_addresses): Stop saving > the $CODE$ section in the so_list structure. > > This files compiles fine again after this change is applied. > > Would that be OK to apply? I think it would be better to revise the code to set so->addr_low and so->addr_high to sec->addr and sec->endaddr respectively. You'll also have to move this block of code to the end of the function. Kevin