From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6386 invoked by alias); 7 Aug 2007 20:42:06 -0000 Received: (qmail 6357 invoked by uid 22791); 7 Aug 2007 20:42:06 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 07 Aug 2007 20:42:01 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id F0C722AA105 for ; Tue, 7 Aug 2007 16:41:59 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id eXp+S0EmjhF9 for ; Tue, 7 Aug 2007 16:41:59 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B17A72AA102 for ; Tue, 7 Aug 2007 16:41:59 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 6FAD9E7B54; Tue, 7 Aug 2007 13:45:29 -0700 (PDT) Date: Tue, 07 Aug 2007 20:42:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: [RFA] fix build failure in solib-som.c Message-ID: <20070807204529.GA3681@adacore.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-08/txt/msg00136.txt.bz2 --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 733 Hello, It looks like a change made a month ago that removed a field called textsection from the so_list structure is the cause for a build failure in solib-som.c. I haven't tested this change, but wouldn't the attached patch make sense? I don't think we need to keep track of which section is the text section at this place, since this is done differently somewhere else (in the current_sos method). So I just removed the associated piece of code. 2007-08-07 Joel Brobecker * solib-som.c (som_relocate_section_addresses): Stop saving the $CODE$ section in the so_list structure. This files compiles fine again after this change is applied. Would that be OK to apply? Thanks, -- Joel --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="solib-som.c.diff" Content-length: 746 Index: solib-som.c =================================================================== RCS file: /cvs/src/src/gdb/solib-som.c,v retrieving revision 1.11 diff -u -p -r1.11 solib-som.c --- solib-som.c 2 Jul 2007 22:01:09 -0000 1.11 +++ solib-som.c 7 Aug 2007 20:35:36 -0000 @@ -113,13 +113,6 @@ som_relocate_section_addresses (struct s { flagword aflag = bfd_get_section_flags(so->abfd, sec->the_bfd_section); - /* solib.c does something similar, but it only recognizes ".text", SOM calls - the text section "$CODE$". */ - if (strcmp (sec->the_bfd_section->name, "$CODE$") == 0) - { - so->textsection = sec; - } - if (aflag & SEC_CODE) { sec->addr += so->lm_info->text_addr - so->lm_info->text_link_addr; --GvXjxJ+pjyke8COw--