From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org, gdb-patches@sources.redhat.com
Subject: Re: [RFC] Add call to gdb_exit prior to gdb_start in gdb.cp/ref-params.exp
Date: Sat, 14 Jul 2007 01:09:00 -0000 [thread overview]
Message-ID: <20070714010940.GB21402@caradoc.them.org> (raw)
Message-ID: <20070714010900.CiRR-93H-_JkSqHnoOKKYJvkR3dXXBMXpIn5w2cB4LQ@z> (raw)
In-Reply-To: <20070713165341.17505f34@ironwood.lan>
On Fri, Jul 13, 2007 at 04:53:41PM -0700, Kevin Buettner wrote:
> I've been testing a mep-elf toolchain using the SID simulator. I found
> it necessary to add the call to gdb_exit as indicated in the patch below.
> Without this patch, I get 3 passes and 16 unresolved testcases. With the
> patch, I see 14 passes (and no failures or unresolved testcases).
>
> I took a look at invcations of gdb_start in other tests and found
> that it is customary to invoke gdb_exit prior to gdb_start. (It is
> not _always_ done, but nearly so.) Thus it seems to me that the
> missing call to gdb_exit in ref-params.exp is merely an oversight.
>
> Comments?
Hmm, my runs of ref-params.exp don't show GDB being restarted. I
think it's just reusing the same GDB. Still, your patch looks right.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-07-14 1:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 23:53 Kevin Buettner
2007-07-14 1:25 ` Daniel Jacobowitz [this message]
2007-07-14 1:09 ` Daniel Jacobowitz
2007-07-20 0:03 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070714010940.GB21402@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox