Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFC] Add call to gdb_exit prior to gdb_start in  gdb.cp/ref-params.exp
Date: Fri, 13 Jul 2007 23:53:00 -0000	[thread overview]
Message-ID: <20070713165341.17505f34@ironwood.lan> (raw)

I've been testing a mep-elf toolchain using the SID simulator.  I found
it necessary to add the call to gdb_exit as indicated in the patch below.
Without this patch, I get 3 passes and 16 unresolved testcases.  With the
patch, I see 14 passes (and no failures or unresolved testcases).

I took a look at invcations of gdb_start in other tests and found
that it is customary to invoke gdb_exit prior to gdb_start.  (It is
not _always_ done, but nearly so.)  Thus it seems to me that the
missing call to gdb_exit in ref-params.exp is merely an oversight.

Comments?

	* gdb.cp/ref-params.exp (gdb_start_again): Invoke `gdb_exit'
	prior to `gdb_start'.

Index: testsuite/gdb.cp/ref-params.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/ref-params.exp,v
retrieving revision 1.3
diff -u -p -r1.3 ref-params.exp
--- testsuite/gdb.cp/ref-params.exp	9 Jan 2007 17:59:12 -0000	1.3
+++ testsuite/gdb.cp/ref-params.exp	13 Jul 2007 23:34:03 -0000
@@ -46,6 +46,7 @@ proc gdb_start_again { text } {
     global binfile
     global srcfile
 
+    gdb_exit
     gdb_start
     gdb_reinitialize_dir $srcdir/$subdir
     gdb_load ${binfile}


             reply	other threads:[~2007-07-13 23:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-13 23:53 Kevin Buettner [this message]
2007-07-14  1:25 ` Daniel Jacobowitz
2007-07-14  1:09   ` Daniel Jacobowitz
2007-07-20  0:03 ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070713165341.17505f34@ironwood.lan \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox