From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16479 invoked by alias); 13 Jul 2007 23:53:47 -0000 Received: (qmail 16471 invoked by uid 22791); 13 Jul 2007 23:53:47 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 13 Jul 2007 23:53:44 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l6DNrgq0022475 for ; Fri, 13 Jul 2007 19:53:42 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l6DNrg9V006443 for ; Fri, 13 Jul 2007 19:53:42 -0400 Received: from ironwood.lan (vpn-15-55.rdu.redhat.com [10.11.15.55]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l6DNrfLX010208 for ; Fri, 13 Jul 2007 19:53:42 -0400 Date: Fri, 13 Jul 2007 23:53:00 -0000 From: Kevin Buettner To: gdb-patches@sources.redhat.com Subject: [RFC] Add call to gdb_exit prior to gdb_start in gdb.cp/ref-params.exp Message-ID: <20070713165341.17505f34@ironwood.lan> X-Mailer: Sylpheed-Claws 2.6.0 (GTK+ 2.10.4; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-07/txt/msg00204.txt.bz2 I've been testing a mep-elf toolchain using the SID simulator. I found it necessary to add the call to gdb_exit as indicated in the patch below. Without this patch, I get 3 passes and 16 unresolved testcases. With the patch, I see 14 passes (and no failures or unresolved testcases). I took a look at invcations of gdb_start in other tests and found that it is customary to invoke gdb_exit prior to gdb_start. (It is not _always_ done, but nearly so.) Thus it seems to me that the missing call to gdb_exit in ref-params.exp is merely an oversight. Comments? * gdb.cp/ref-params.exp (gdb_start_again): Invoke `gdb_exit' prior to `gdb_start'. Index: testsuite/gdb.cp/ref-params.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/ref-params.exp,v retrieving revision 1.3 diff -u -p -r1.3 ref-params.exp --- testsuite/gdb.cp/ref-params.exp 9 Jan 2007 17:59:12 -0000 1.3 +++ testsuite/gdb.cp/ref-params.exp 13 Jul 2007 23:34:03 -0000 @@ -46,6 +46,7 @@ proc gdb_start_again { text } { global binfile global srcfile + gdb_exit gdb_start gdb_reinitialize_dir $srcdir/$subdir gdb_load ${binfile}