From: Daniel Jacobowitz <drow@false.org>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [2/10] Remove &builtin_type_ from tdep code (amd64/s390/sparc64)
Date: Tue, 12 Jun 2007 15:09:00 -0000 [thread overview]
Message-ID: <20070612150917.GA16068@caradoc.them.org> (raw)
In-Reply-To: <200706082314.l58NEw7j016615@d12av02.megacenter.de.ibm.com>
On Sat, Jun 09, 2007 at 01:14:58AM +0200, Ulrich Weigand wrote:
> Hello,
>
> a number of platforms (amd64, s390, sparc64) were using a global data
> structure containing pointers to types describing the register types.
> This is broken if those types need to be platform-specific.
>
> The following patch removes those global data structures, and converts
> the affected architectures to simply return the types dynamically from
> the register_type callback, as all other platforms do as well.
>
> Tested on s390-ibm-linux and s390x-ibm-linux.
>
> I'd appreciate testers of the amd64 and sparc64 parts of this patch!
/space/fsf/commit/src/gdb/amd64-tdep.c:106: error:
'AMD64_FCRTL_REGNUM' undeclared (first use in this function)
With that fixed, x86_64-linux test results are unchanged.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-06-12 15:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-08 23:15 Ulrich Weigand
2007-06-12 15:09 ` Daniel Jacobowitz [this message]
2007-06-12 15:57 ` Ulrich Weigand
2007-06-12 15:14 ` Daniel Jacobowitz
2007-06-12 16:07 ` Ulrich Weigand
2007-06-13 7:08 ` Vladimir Prus
2007-06-13 13:06 ` Ulrich Weigand
2007-06-13 13:09 ` Daniel Jacobowitz
2007-06-13 13:17 ` Ulrich Weigand
2007-06-13 13:36 ` Daniel Jacobowitz
2007-06-13 13:57 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070612150917.GA16068@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox