From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18167 invoked by alias); 12 Jun 2007 15:09:08 -0000 Received: (qmail 18156 invoked by uid 22791); 12 Jun 2007 15:09:07 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 12 Jun 2007 15:09:05 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 49822982DE; Tue, 12 Jun 2007 15:09:03 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 0D72D982DC; Tue, 12 Jun 2007 15:09:02 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1Hy7zh-0000ja-AR; Tue, 12 Jun 2007 11:09:17 -0400 Date: Tue, 12 Jun 2007 15:09:00 -0000 From: Daniel Jacobowitz To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [2/10] Remove &builtin_type_ from tdep code (amd64/s390/sparc64) Message-ID: <20070612150917.GA16068@caradoc.them.org> Mail-Followup-To: Ulrich Weigand , gdb-patches@sourceware.org References: <200706082314.l58NEw7j016615@d12av02.megacenter.de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200706082314.l58NEw7j016615@d12av02.megacenter.de.ibm.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00177.txt.bz2 On Sat, Jun 09, 2007 at 01:14:58AM +0200, Ulrich Weigand wrote: > Hello, > > a number of platforms (amd64, s390, sparc64) were using a global data > structure containing pointers to types describing the register types. > This is broken if those types need to be platform-specific. > > The following patch removes those global data structures, and converts > the affected architectures to simply return the types dynamically from > the register_type callback, as all other platforms do as well. > > Tested on s390-ibm-linux and s390x-ibm-linux. > > I'd appreciate testers of the amd64 and sparc64 parts of this patch! /space/fsf/commit/src/gdb/amd64-tdep.c:106: error: 'AMD64_FCRTL_REGNUM' undeclared (first use in this function) With that fixed, x86_64-linux test results are unchanged. -- Daniel Jacobowitz CodeSourcery