[rfc][13/13] Eliminate read_register: Remove definition

[rfc][13/13] Eliminate read_register: Remove definition

[Ulrich Weigand]

Hello,

this is it!  No more users of read_register et al. 

Bye,
Ulrich


ChangeLog:

	* regcache.c (read_register, read_register_pid): Remove.
	(write_register, write_register_pid): Likewise.
	* regcache.h (read_register, read_register_pid): Remove prototype.
	(write_register, write_register_pid): Likewise.


diff -urNp gdb-orig/gdb/regcache.c gdb-head/gdb/regcache.c
--- gdb-orig/gdb/regcache.c	2007-06-01 18:21:40.033980794 +0200
+++ gdb-head/gdb/regcache.c	2007-06-01 18:21:49.076007604 +0200
@@ -754,73 +754,6 @@ register_offset_hack (struct gdbarch *gd
   return descr->register_offset[regnum];
 }
 
-/* Return the contents of register REGNUM as an unsigned integer.  */
-
-ULONGEST
-read_register (int regnum)
-{
-  gdb_byte *buf = alloca (register_size (current_gdbarch, regnum));
-  gdb_assert (current_regcache != NULL);
-  gdb_assert (current_regcache->descr->gdbarch == current_gdbarch);
-  regcache_cooked_read (current_regcache, regnum, buf);
-  return (extract_unsigned_integer (buf, register_size (current_gdbarch, regnum)));
-}
-
-ULONGEST
-read_register_pid (int regnum, ptid_t ptid)
-{
-  ptid_t save_ptid;
-  int save_pid;
-  CORE_ADDR retval;
-
-  if (ptid_equal (ptid, inferior_ptid))
-    return read_register (regnum);
-
-  save_ptid = inferior_ptid;
-
-  inferior_ptid = ptid;
-
-  retval = read_register (regnum);
-
-  inferior_ptid = save_ptid;
-
-  return retval;
-}
-
-/* Store VALUE into the raw contents of register number REGNUM.  */
-
-void
-write_register (int regnum, LONGEST val)
-{
-  void *buf;
-  int size;
-  size = register_size (current_gdbarch, regnum);
-  buf = alloca (size);
-  store_signed_integer (buf, size, (LONGEST) val);
-  gdb_assert (current_regcache != NULL);
-  gdb_assert (current_regcache->descr->gdbarch == current_gdbarch);
-  regcache_cooked_write (current_regcache, regnum, buf);
-}
-
-void
-write_register_pid (int regnum, CORE_ADDR val, ptid_t ptid)
-{
-  ptid_t save_ptid;
-
-  if (ptid_equal (ptid, inferior_ptid))
-    {
-      write_register (regnum, val);
-      return;
-    }
-
-  save_ptid = inferior_ptid;
-
-  inferior_ptid = ptid;
-
-  write_register (regnum, val);
-
-  inferior_ptid = save_ptid;
-}
 
 /* Supply register REGNUM, whose contents are stored in BUF, to REGCACHE.  */
 
diff -urNp gdb-orig/gdb/regcache.h gdb-head/gdb/regcache.h
--- gdb-orig/gdb/regcache.h	2007-05-15 20:28:59.000000000 +0200
+++ gdb-head/gdb/regcache.h	2007-06-01 18:21:49.118001556 +0200
@@ -161,15 +161,4 @@ extern void regcache_cpy_no_passthrough 
 
 extern void registers_changed (void);
 
-
-/* Rename to read_unsigned_register()? */
-extern ULONGEST read_register (int regnum);
-
-/* Rename to read_unsigned_register_pid()? */
-extern ULONGEST read_register_pid (int regnum, ptid_t ptid);
-
-extern void write_register (int regnum, LONGEST val);
-
-extern void write_register_pid (int regnum, CORE_ADDR val, ptid_t ptid);
-
 #endif /* REGCACHE_H */
-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com

Re: [rfc][13/13] Eliminate read_register: Remove definition

[Daniel Jacobowitz]

On Thu, Jun 07, 2007 at 11:01:33PM +0200, Ulrich Weigand wrote:
> Hello,
> 
> this is it!  No more users of read_register et al. 

I looked at all of these, and didn't see any problems.  Great!

-- 
Daniel Jacobowitz
CodeSourcery