From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2703 invoked by alias); 7 Jun 2007 21:01:43 -0000 Received: (qmail 2684 invoked by uid 22791); 7 Jun 2007 21:01:42 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate2.de.ibm.com (HELO mtagate2.de.ibm.com) (195.212.29.151) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 07 Jun 2007 21:01:36 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate2.de.ibm.com (8.13.8/8.13.8) with ESMTP id l57L1YDV158008 for ; Thu, 7 Jun 2007 21:01:34 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l57L1Y6P3997824 for ; Thu, 7 Jun 2007 23:01:34 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l57L1X0r021567 for ; Thu, 7 Jun 2007 23:01:33 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l57L1XNt021564 for ; Thu, 7 Jun 2007 23:01:33 +0200 Message-Id: <200706072101.l57L1XNt021564@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 7 Jun 2007 23:01:33 +0200 Subject: [rfc][13/13] Eliminate read_register: Remove definition To: gdb-patches@sourceware.org Date: Thu, 07 Jun 2007 21:01:00 -0000 From: "Ulrich Weigand" X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-06/txt/msg00092.txt.bz2 Hello, this is it! No more users of read_register et al. Bye, Ulrich ChangeLog: * regcache.c (read_register, read_register_pid): Remove. (write_register, write_register_pid): Likewise. * regcache.h (read_register, read_register_pid): Remove prototype. (write_register, write_register_pid): Likewise. diff -urNp gdb-orig/gdb/regcache.c gdb-head/gdb/regcache.c --- gdb-orig/gdb/regcache.c 2007-06-01 18:21:40.033980794 +0200 +++ gdb-head/gdb/regcache.c 2007-06-01 18:21:49.076007604 +0200 @@ -754,73 +754,6 @@ register_offset_hack (struct gdbarch *gd return descr->register_offset[regnum]; } -/* Return the contents of register REGNUM as an unsigned integer. */ - -ULONGEST -read_register (int regnum) -{ - gdb_byte *buf = alloca (register_size (current_gdbarch, regnum)); - gdb_assert (current_regcache != NULL); - gdb_assert (current_regcache->descr->gdbarch == current_gdbarch); - regcache_cooked_read (current_regcache, regnum, buf); - return (extract_unsigned_integer (buf, register_size (current_gdbarch, regnum))); -} - -ULONGEST -read_register_pid (int regnum, ptid_t ptid) -{ - ptid_t save_ptid; - int save_pid; - CORE_ADDR retval; - - if (ptid_equal (ptid, inferior_ptid)) - return read_register (regnum); - - save_ptid = inferior_ptid; - - inferior_ptid = ptid; - - retval = read_register (regnum); - - inferior_ptid = save_ptid; - - return retval; -} - -/* Store VALUE into the raw contents of register number REGNUM. */ - -void -write_register (int regnum, LONGEST val) -{ - void *buf; - int size; - size = register_size (current_gdbarch, regnum); - buf = alloca (size); - store_signed_integer (buf, size, (LONGEST) val); - gdb_assert (current_regcache != NULL); - gdb_assert (current_regcache->descr->gdbarch == current_gdbarch); - regcache_cooked_write (current_regcache, regnum, buf); -} - -void -write_register_pid (int regnum, CORE_ADDR val, ptid_t ptid) -{ - ptid_t save_ptid; - - if (ptid_equal (ptid, inferior_ptid)) - { - write_register (regnum, val); - return; - } - - save_ptid = inferior_ptid; - - inferior_ptid = ptid; - - write_register (regnum, val); - - inferior_ptid = save_ptid; -} /* Supply register REGNUM, whose contents are stored in BUF, to REGCACHE. */ diff -urNp gdb-orig/gdb/regcache.h gdb-head/gdb/regcache.h --- gdb-orig/gdb/regcache.h 2007-05-15 20:28:59.000000000 +0200 +++ gdb-head/gdb/regcache.h 2007-06-01 18:21:49.118001556 +0200 @@ -161,15 +161,4 @@ extern void regcache_cpy_no_passthrough extern void registers_changed (void); - -/* Rename to read_unsigned_register()? */ -extern ULONGEST read_register (int regnum); - -/* Rename to read_unsigned_register_pid()? */ -extern ULONGEST read_register_pid (int regnum, ptid_t ptid); - -extern void write_register (int regnum, LONGEST val); - -extern void write_register_pid (int regnum, CORE_ADDR val, ptid_t ptid); - #endif /* REGCACHE_H */ -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com