From: Daniel Jacobowitz <drow@false.org>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: gdb-patches@sourceware.org,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Eli Zaretskii <eliz@gnu.org>
Subject: Re: [rfc] Propagate constants into MIPS ABI routines, remove some knobs
Date: Wed, 02 May 2007 13:29:00 -0000 [thread overview]
Message-ID: <20070502132910.GA16721@caradoc.them.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0705021400360.28428@perivale.mips.com>
On Wed, May 02, 2007 at 02:07:12PM +0100, Maciej W. Rozycki wrote:
> It seems fine for me. I was about to submit the change I promised a
> while ago -- to remove some pointless calls to mips_abi_regsize() -- but
> yours actually does all of that already (modulo some cosmetic clean-ups).
>
> I'd be happier if the change was done in two steps though as it groups
> two independent sets. Perhaps indeed it should?
>
> Here's my change:
>
> 2007-04-18 Maciej W. Rozycki <macro@mips.com>
>
> * mips-tdep.c (mips_o32_push_dummy_call): Remove conditions
> based on mips_abi_regsize() whose result is known in advance.
> (mips_o64_push_dummy_call): Likewise.
Fine by me. Could you commit this?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-05-02 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 20:37 Daniel Jacobowitz
2007-05-01 23:10 ` Thiemo Seufer
2007-05-01 23:40 ` Daniel Jacobowitz
2007-05-02 3:04 ` Eli Zaretskii
2007-05-02 11:07 ` Daniel Jacobowitz
2007-05-02 19:07 ` Eli Zaretskii
2007-05-02 13:07 ` Maciej W. Rozycki
2007-05-02 13:29 ` Daniel Jacobowitz [this message]
2007-05-02 13:40 ` Maciej W. Rozycki
2007-05-16 14:17 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070502132910.GA16721@caradoc.them.org \
--to=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
--cc=macro@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox