Re: [rfc] Propagate constants into MIPS ABI routines, remove some knobs

[Thiemo Seufer <ths@networkno.de>]

Daniel Jacobowitz wrote:
> This patch removes the "set mips stack-arg-size" and "set mips
> saved-gpreg-size" commands.  As far as I can tell, they are obsoleted
> by "set mips abi".  saved-gpreg-size was originally added for EABI
> -mgp32, which was not setting any e_flags bit that GDB could use to
> identify it; but nowadays we have an ABI marker in a section name, and
> we have the "set mips abi" command to specify it manually.
> 
> So I replaced uses of the separate mips_stack_argsize with
> mips_abi_regsize, and then I propagated constant ABI register sizes
> into the n32, n64, o32, and o64 routines and deleted some of the
> obvious resulting dead code.  If we've decided to have separate
> implementations for all of these we may as well make them more
> readable.  I have a lot of ABI-related failures on mips64-linux,
> which I'll track down some other time.
> 
> Maciej, do you know of anyone who needs to use the stack-arg-size /
> saved-gpreg-size commands?  I couldn't find any uses when I searched
> for them.  I didn't touch the FP options in this pass.

Maybe we should have a .mdebug.abi32-fp64 ABI marker for -mabi=32 -mfp64
objects. I probably should also move over to binutils so it can handle
assembler files. What do you think?


Thiemo