From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6290 invoked by alias); 1 May 2007 23:10:01 -0000 Received: (qmail 6255 invoked by uid 22791); 1 May 2007 23:10:01 -0000 X-Spam-Check-By: sourceware.org Received: from phoenix.bawue.net (HELO mail.bawue.net) (193.7.176.60) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 01 May 2007 23:09:57 +0000 Received: from lagash (88-106-169-123.dynamic.dsl.as9105.com [88.106.169.123]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.bawue.net (Postfix) with ESMTP id EAD8BB8D44; Wed, 2 May 2007 01:09:54 +0200 (CEST) Received: from ths by lagash with local (Exim 4.67) (envelope-from ) id 1Hj1UZ-0003wF-Ig; Wed, 02 May 2007 00:10:43 +0100 Date: Tue, 01 May 2007 23:10:00 -0000 To: gdb-patches@sourceware.org, "Maciej W. Rozycki" , Eli Zaretskii Subject: Re: [rfc] Propagate constants into MIPS ABI routines, remove some knobs Message-ID: <20070501231043.GF30083@networkno.de> References: <20070501203647.GB23630@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070501203647.GB23630@caradoc.them.org> User-Agent: Mutt/1.5.13 (2006-08-11) From: Thiemo Seufer X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00020.txt.bz2 Daniel Jacobowitz wrote: > This patch removes the "set mips stack-arg-size" and "set mips > saved-gpreg-size" commands. As far as I can tell, they are obsoleted > by "set mips abi". saved-gpreg-size was originally added for EABI > -mgp32, which was not setting any e_flags bit that GDB could use to > identify it; but nowadays we have an ABI marker in a section name, and > we have the "set mips abi" command to specify it manually. > > So I replaced uses of the separate mips_stack_argsize with > mips_abi_regsize, and then I propagated constant ABI register sizes > into the n32, n64, o32, and o64 routines and deleted some of the > obvious resulting dead code. If we've decided to have separate > implementations for all of these we may as well make them more > readable. I have a lot of ABI-related failures on mips64-linux, > which I'll track down some other time. > > Maciej, do you know of anyone who needs to use the stack-arg-size / > saved-gpreg-size commands? I couldn't find any uses when I searched > for them. I didn't touch the FP options in this pass. Maybe we should have a .mdebug.abi32-fp64 ABI marker for -mabi=32 -mfp64 objects. I probably should also move over to binutils so it can handle assembler files. What do you think? Thiemo