From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3597 invoked by alias); 2 May 2007 13:29:20 -0000 Received: (qmail 3587 invoked by uid 22791); 2 May 2007 13:29:19 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 02 May 2007 13:29:17 +0000 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 5BB804B267; Wed, 2 May 2007 08:29:15 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id E21904B262; Wed, 2 May 2007 08:29:10 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1HjEtK-0004Q5-Aq; Wed, 02 May 2007 09:29:10 -0400 Date: Wed, 02 May 2007 13:29:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, "Maciej W. Rozycki" , Eli Zaretskii Subject: Re: [rfc] Propagate constants into MIPS ABI routines, remove some knobs Message-ID: <20070502132910.GA16721@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sourceware.org, "Maciej W. Rozycki" , Eli Zaretskii References: <20070501203647.GB23630@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00030.txt.bz2 On Wed, May 02, 2007 at 02:07:12PM +0100, Maciej W. Rozycki wrote: > It seems fine for me. I was about to submit the change I promised a > while ago -- to remove some pointless calls to mips_abi_regsize() -- but > yours actually does all of that already (modulo some cosmetic clean-ups). > > I'd be happier if the change was done in two steps though as it groups > two independent sets. Perhaps indeed it should? > > Here's my change: > > 2007-04-18 Maciej W. Rozycki > > * mips-tdep.c (mips_o32_push_dummy_call): Remove conditions > based on mips_abi_regsize() whose result is known in advance. > (mips_o64_push_dummy_call): Likewise. Fine by me. Could you commit this? -- Daniel Jacobowitz CodeSourcery