From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: mark.kettenis@xs4all.nl (Mark Kettenis)
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] [00/14] Push REGCACHE into target_fetch/store_registers
Date: Tue, 01 May 2007 23:12:00 -0000 [thread overview]
Message-ID: <200705012312.l41NCTWV013055@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200705012039.l41KdXI5012430@brahms.sibelius.xs4all.nl> from "Mark Kettenis" at May 01, 2007 10:39:34 PM
Mark Kettenis wrote:
> 1. core_fns/core_read_registers should really die (it'd already
> deprecated) and replaced by gdbarch_regset_from_core_section().
>
> 2. supply_gregset, supply_fpregset, fill_gregset or fill_fpregset
> should really be replaced by something like
> gdbarch_regset_from_core_section().
I agree, but those changes are difficult to make without having
the target to test on. In particular making sure the osabi sniffer
detects the core file correctly is something that really needs
to be tested ... That's why I left those things as-is for now.
> That said, this diff is great progress, and I think it should go in
> ASAP. It's probably polite to give other responsable maintainers the
> opportunity to react to the diff. So consider this an explicit ok for
> the i387 targets.
Thanks! I'll wait for a couple of days for further comments before
checking it in (but not too long -- I really don't want mainline to
change so much I'll have to re-do the patch set ...).
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2007-05-01 23:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 1:26 Ulrich Weigand
2007-05-01 20:39 ` Mark Kettenis
2007-05-01 21:05 ` Daniel Jacobowitz
2007-05-01 23:12 ` Ulrich Weigand [this message]
2007-05-06 14:39 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705012312.l41NCTWV013055@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox