From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7029 invoked by alias); 1 May 2007 23:12:35 -0000 Received: (qmail 7021 invoked by uid 22791); 1 May 2007 23:12:35 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 01 May 2007 23:12:33 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id l41NCTGs228008 for ; Tue, 1 May 2007 23:12:29 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l41NCTsi3637494 for ; Wed, 2 May 2007 01:12:29 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l41NCTfd013058 for ; Wed, 2 May 2007 01:12:29 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l41NCTWV013055; Wed, 2 May 2007 01:12:29 +0200 Message-Id: <200705012312.l41NCTWV013055@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 2 May 2007 01:12:29 +0200 Subject: Re: [rfc] [00/14] Push REGCACHE into target_fetch/store_registers To: mark.kettenis@xs4all.nl (Mark Kettenis) Date: Tue, 01 May 2007 23:12:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <200705012039.l41KdXI5012430@brahms.sibelius.xs4all.nl> from "Mark Kettenis" at May 01, 2007 10:39:34 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00021.txt.bz2 Mark Kettenis wrote: > 1. core_fns/core_read_registers should really die (it'd already > deprecated) and replaced by gdbarch_regset_from_core_section(). > > 2. supply_gregset, supply_fpregset, fill_gregset or fill_fpregset > should really be replaced by something like > gdbarch_regset_from_core_section(). I agree, but those changes are difficult to make without having the target to test on. In particular making sure the osabi sniffer detects the core file correctly is something that really needs to be tested ... That's why I left those things as-is for now. > That said, this diff is great progress, and I think it should go in > ASAP. It's probably polite to give other responsable maintainers the > opportunity to react to the diff. So consider this an explicit ok for > the i387 targets. Thanks! I'll wait for a couple of days for further comments before checking it in (but not too long -- I really don't want mainline to change so much I'll have to re-do the patch set ...). Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com