From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: uweigand@de.ibm.com
Cc: gdb-patches@sourceware.org
Subject: Re: [rfc] [00/14] Push REGCACHE into target_fetch/store_registers
Date: Tue, 01 May 2007 20:39:00 -0000 [thread overview]
Message-ID: <200705012039.l41KdXI5012430@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <200705010126.l411Q814016557@d12av02.megacenter.de.ibm.com> (uweigand@de.ibm.com)
> Date: Tue, 1 May 2007 03:26:04 +0200 (CEST)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
>
> I'd appreciate any feedback! Do you think this would be OK to commit?
Some general notes:
1. core_fns/core_read_registers should really die (it'd already
deprecated) and replaced by gdbarch_regset_from_core_section().
2. supply_gregset, supply_fpregset, fill_gregset or fill_fpregset
should really be replaced by something like
gdbarch_regset_from_core_section().
That said, this diff is great progress, and I think it should go in
ASAP. It's probably polite to give other responsable maintainers the
opportunity to react to the diff. So consider this an explicit ok for
the i387 targets.
Mark
next prev parent reply other threads:[~2007-05-01 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 1:26 Ulrich Weigand
2007-05-01 20:39 ` Mark Kettenis [this message]
2007-05-01 21:05 ` Daniel Jacobowitz
2007-05-01 23:12 ` Ulrich Weigand
2007-05-06 14:39 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705012039.l41KdXI5012430@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox