From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-48694-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13655 invoked by alias); 1 May 2007 20:39:42 -0000
Received: (qmail 13646 invoked by uid 22791); 1 May 2007 20:39:41 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 01 May 2007 21:39:39 +0100
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.0/8.14.0) with ESMTP id l41KdY8H000578; 	Tue, 1 May 2007 22:39:34 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.0/8.14.0/Submit) id l41KdXI5012430; 	Tue, 1 May 2007 22:39:34 +0200 (CEST)
Date: Tue, 01 May 2007 20:39:00 -0000
Message-Id: <200705012039.l41KdXI5012430@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: uweigand@de.ibm.com
CC: gdb-patches@sourceware.org
In-reply-to: <200705010126.l411Q814016557@d12av02.megacenter.de.ibm.com> 	(uweigand@de.ibm.com)
Subject: Re: [rfc] [00/14] Push REGCACHE into target_fetch/store_registers
References:  <200705010126.l411Q814016557@d12av02.megacenter.de.ibm.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-05/txt/msg00017.txt.bz2

> Date: Tue, 1 May 2007 03:26:04 +0200 (CEST)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
> 
> I'd appreciate any feedback!  Do you think this would be OK to commit?

Some general notes:

1. core_fns/core_read_registers should really die (it'd already
   deprecated) and replaced by gdbarch_regset_from_core_section().

2. supply_gregset, supply_fpregset, fill_gregset or fill_fpregset
   should really be replaced by something like
   gdbarch_regset_from_core_section().

That said, this diff is great progress, and I think it should go in
ASAP.  It's probably polite to give other responsable maintainers the
opportunity to react to the diff.  So consider this an explicit ok for
the i387 targets.

Mark