From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: kevinb@redhat.com (Kevin Buettner)
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] dwarf2_read_address(): sign extend as appropriate
Date: Mon, 23 Apr 2007 15:06:00 -0000 [thread overview]
Message-ID: <200704231505.l3NF5KV5025451@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20070420163312.56701614@ironwood.lan> from "Kevin Buettner" at Apr 20, 2007 04:33:12 PM
Kevin Buettner wrote:
> Any comments regarding the patch below?
>
> I wrote it last summer, so my memory about it is rather hazy aside
> from the fact that it fixed a bunch of C++ frame base problems on
> mips64 targets.
>
> It shouldn't affect any architecture other than mips because mips is
> the only one which defines an integer_to_address method. It also
> addresses Andrew's FIXME comment from nearly four years ago...
>
> * dwarf2expr.c (unsigned_address_type): Add forward declaration.
> (dwarf2_read_address): Sign extend return address as required by
> target architecture.
I've recently changed a very similar place, dwarf_expr_read_reg in
dwarf2loc.c, to use a new "address_from_register" function to solve
the same problem:
http://sourceware.org/ml/gdb-patches/2006-11/msg00134.html
Is there any reason you couldn't use the same function here?
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2007-04-23 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-21 3:13 Kevin Buettner
2007-04-23 15:06 ` Ulrich Weigand [this message]
2007-04-23 16:57 ` Kevin Buettner
2007-04-23 18:19 ` Daniel Jacobowitz
2007-04-23 21:51 ` Kevin Buettner
2007-04-24 21:34 ` Daniel Jacobowitz
2007-04-27 21:30 ` Kevin Buettner
2007-04-27 22:16 ` Daniel Jacobowitz
2007-04-27 22:47 ` Kevin Buettner
2007-04-28 5:38 ` Daniel Jacobowitz
2007-04-23 22:51 ` Andreas Schwab
2007-04-24 18:13 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704231505.l3NF5KV5025451@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox