From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1094 invoked by alias); 23 Apr 2007 15:05:27 -0000 Received: (qmail 1086 invoked by uid 22791); 23 Apr 2007 15:05:26 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 23 Apr 2007 16:05:24 +0100 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id l3NF5L2H320584 for ; Mon, 23 Apr 2007 15:05:21 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l3NF5KUn4001888 for ; Mon, 23 Apr 2007 17:05:21 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l3NF5KM3025457 for ; Mon, 23 Apr 2007 17:05:20 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l3NF5KV5025451; Mon, 23 Apr 2007 17:05:20 +0200 Message-Id: <200704231505.l3NF5KV5025451@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 23 Apr 2007 17:05:20 +0200 Subject: Re: [RFC] dwarf2_read_address(): sign extend as appropriate To: kevinb@redhat.com (Kevin Buettner) Date: Mon, 23 Apr 2007 15:06:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sources.redhat.com In-Reply-To: <20070420163312.56701614@ironwood.lan> from "Kevin Buettner" at Apr 20, 2007 04:33:12 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00305.txt.bz2 Kevin Buettner wrote: > Any comments regarding the patch below? > > I wrote it last summer, so my memory about it is rather hazy aside > from the fact that it fixed a bunch of C++ frame base problems on > mips64 targets. > > It shouldn't affect any architecture other than mips because mips is > the only one which defines an integer_to_address method. It also > addresses Andrew's FIXME comment from nearly four years ago... > > * dwarf2expr.c (unsigned_address_type): Add forward declaration. > (dwarf2_read_address): Sign extend return address as required by > target architecture. I've recently changed a very similar place, dwarf_expr_read_reg in dwarf2loc.c, to use a new "address_from_register" function to solve the same problem: http://sourceware.org/ml/gdb-patches/2006-11/msg00134.html Is there any reason you couldn't use the same function here? Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com