From: Daniel Jacobowitz <drow@false.org>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] dwarf2_read_address(): sign extend as appropriate
Date: Fri, 27 Apr 2007 22:16:00 -0000 [thread overview]
Message-ID: <20070427214829.GA21596@caradoc.them.org> (raw)
In-Reply-To: <20070427141018.1430725b@ironwood.lan>
On Fri, Apr 27, 2007 at 02:10:18PM -0700, Kevin Buettner wrote:
> I decided to give the `value_as_address' approach a try. It worked
> as expected when I tried running it against a MIPS target.
>
> Comments?
>
> * dwarf2expr.c (unsigned_address_type): Add forward declaration.
> (dwarf2_read_address): Sign extend return address as required by
> target architecture.
Fine with me, although I would request you not to put code in the
comments; we can figure it out again later, and I find commented out
code too confusing.
Do you happen to have more MIPS patches lying around? I'm in the
middle of enabling CFI, based on some old patches of yours; I
encountered yet another new address sign / size confusion.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-04-27 21:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-21 3:13 Kevin Buettner
2007-04-23 15:06 ` Ulrich Weigand
2007-04-23 16:57 ` Kevin Buettner
2007-04-23 18:19 ` Daniel Jacobowitz
2007-04-23 21:51 ` Kevin Buettner
2007-04-24 21:34 ` Daniel Jacobowitz
2007-04-27 21:30 ` Kevin Buettner
2007-04-27 22:16 ` Daniel Jacobowitz [this message]
2007-04-27 22:47 ` Kevin Buettner
2007-04-28 5:38 ` Daniel Jacobowitz
2007-04-23 22:51 ` Andreas Schwab
2007-04-24 18:13 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070427214829.GA21596@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox