From: Daniel Jacobowitz <drow@false.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Joel Brobecker <brobecker@adacore.com>,
gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Subject: Re: [RFA/libiberty] Fix documentation issues in filename_cmp.c
Date: Sat, 07 Apr 2007 17:35:00 -0000 [thread overview]
Message-ID: <20070407173500.GC24650@caradoc.them.org> (raw)
In-Reply-To: <u3b3d50ul.fsf@gnu.org>
On Fri, Apr 06, 2007 at 12:05:54PM +0300, Eli Zaretskii wrote:
> > 2. The possible introduction of a bug with certain locales because
> > the function used in place of strcasecmp uses tolower.
> >
> > For this one, as I said, I don't know, and I'm not sure where
> > to start looking for the answer.
>
> How about using your function with LANG set to various values? That
> should at least tell us whether strcasecmp and tolower do the same
> thing; if they do, there's no problem here.
For what it's worth, here's what I know about this:
1. POSIX says:
In the POSIX locale, strcasecmp() and strncasecmp() shall behave as if
the strings had been converted to lowercase and then a byte comparison
performed. The results are unspecified in other locales.
2. Glibc's strcasecmp uses tolower and honors LC_COLLATE.
Which behavior do we want here, anyway? I'm not sure...
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-04-07 17:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-05 17:27 Joel Brobecker
2007-04-05 18:36 ` DJ Delorie
2007-04-06 6:02 ` Joel Brobecker
2007-04-05 18:44 ` Eli Zaretskii
2007-04-06 6:10 ` Joel Brobecker
2007-04-06 9:05 ` Eli Zaretskii
2007-04-06 10:00 ` Dave Korn
2007-04-07 17:35 ` Daniel Jacobowitz [this message]
2007-04-07 17:52 ` Eli Zaretskii
2007-04-11 7:24 ` Joel Brobecker
2007-04-11 18:28 ` Eli Zaretskii
2007-04-11 20:33 ` Ian Lance Taylor
2007-05-03 15:36 ` [RFA/libiberty] use TOLOWER instead of tolower " Joel Brobecker
2007-05-03 16:31 ` Ian Lance Taylor
2007-05-03 23:40 ` Joel Brobecker
2007-05-04 7:18 ` Eli Zaretskii
2007-04-11 7:27 ` [RFA/libiberty] Fix documentation issues " Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070407173500.GC24650@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox