From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30981 invoked by alias); 7 Apr 2007 17:35:05 -0000 Received: (qmail 30951 invoked by uid 22791); 7 Apr 2007 17:35:05 -0000 X-Spam-Check-By: sourceware.org Received: from return.false.org (HELO return.false.org) (66.207.162.98) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 07 Apr 2007 18:35:02 +0100 Received: from return.false.org (localhost [127.0.0.1]) by return.false.org (Postfix) with ESMTP id 5FAA44B267; Sat, 7 Apr 2007 12:35:01 -0500 (CDT) Received: from caradoc.them.org (dsl093-172-095.pit1.dsl.speakeasy.net [66.93.172.95]) by return.false.org (Postfix) with ESMTP id 37B974B262; Sat, 7 Apr 2007 12:35:01 -0500 (CDT) Received: from drow by caradoc.them.org with local (Exim 4.63) (envelope-from ) id 1HaEoW-0006jo-Nt; Sat, 07 Apr 2007 13:35:00 -0400 Date: Sat, 07 Apr 2007 17:35:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: Joel Brobecker , gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Subject: Re: [RFA/libiberty] Fix documentation issues in filename_cmp.c Message-ID: <20070407173500.GC24650@caradoc.them.org> Mail-Followup-To: Eli Zaretskii , Joel Brobecker , gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org References: <20070405172720.GB9281@adacore.com> <20070406061218.GB3471@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.14+cvs20070313 (2007-03-13) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00046.txt.bz2 On Fri, Apr 06, 2007 at 12:05:54PM +0300, Eli Zaretskii wrote: > > 2. The possible introduction of a bug with certain locales because > > the function used in place of strcasecmp uses tolower. > > > > For this one, as I said, I don't know, and I'm not sure where > > to start looking for the answer. > > How about using your function with LANG set to various values? That > should at least tell us whether strcasecmp and tolower do the same > thing; if they do, there's no problem here. For what it's worth, here's what I know about this: 1. POSIX says: In the POSIX locale, strcasecmp() and strncasecmp() shall behave as if the strings had been converted to lowercase and then a byte comparison performed. The results are unspecified in other locales. 2. Glibc's strcasecmp uses tolower and honors LC_COLLATE. Which behavior do we want here, anyway? I'm not sure... -- Daniel Jacobowitz CodeSourcery