Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: gdb-patches@sourceware.org
Subject: [RFA/libiberty] Fix documentation issues in filename_cmp.c
Date: Thu, 05 Apr 2007 17:27:00 -0000	[thread overview]
Message-ID: <20070405172720.GB9281@adacore.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

Hello,

The attached patch incorporates all the documentation changes that Eli
has recommended.  No code change.

2007-04-05  Joel Brobecker  <brobecker@adacore.com>

        * filename_cmp.c (filename_cmp): Improve documentation.

Tested on x86-linux by rebuilding GDB. OK to apply?

Thanks,
-- 
Joel

[-- Attachment #2: filename_cmp.2.diff --]
[-- Type: text/plain, Size: 1377 bytes --]

Index: libiberty/filename_cmp.c
===================================================================
RCS file: /cvs/src/src/libiberty/filename_cmp.c,v
retrieving revision 1.2
diff -u -p -r1.2 filename_cmp.c
--- libiberty/filename_cmp.c	2 Apr 2007 11:20:52 -0000	1.2
+++ libiberty/filename_cmp.c	5 Apr 2007 17:21:47 -0000
@@ -31,12 +31,13 @@
 
 @deftypefn Extension int filename_cmp (const char *@var{s1}, const char *@var{s2})
 
-Return zero if the two paths @var{s1} and @var{s2} are equivalent.
-If not equivalent, the returned value is similar to what strcmp would
-return.  In other words, it returns a negative value if @var{s1} is less
-than @var{s2}, or a positive value if @var{s2} is greater than @var{s2}.
+Return zero if the two file names @var{s1} and @var{s2} are equivalent.
+If not equivalent, the returned value is similar to what @code{strcmp}
+would return.  In other words, it returns a negative value if @var{s1}
+is less than @var{s2}, or a positive value if @var{s2} is greater than
+@var{s2}.
 
-This function does not normalize path names. As a result, this function
+This function does not normalize file names.  As a result, this function
 will treat filenames that are spelled differently as different even in
 the case when the two filenames point to the same underlying file.
 However, it does handle the fact that on DOS-like file systems, forward

             reply	other threads:[~2007-04-05 17:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-05 17:27 Joel Brobecker [this message]
2007-04-05 18:36 ` DJ Delorie
2007-04-06  6:02   ` Joel Brobecker
2007-04-05 18:44 ` Eli Zaretskii
2007-04-06  6:10   ` Joel Brobecker
2007-04-06  9:05     ` Eli Zaretskii
2007-04-06 10:00       ` Dave Korn
2007-04-07 17:35       ` Daniel Jacobowitz
2007-04-07 17:52         ` Eli Zaretskii
2007-04-11  7:24           ` Joel Brobecker
2007-04-11 18:28             ` Eli Zaretskii
2007-04-11 20:33               ` Ian Lance Taylor
2007-05-03 15:36                 ` [RFA/libiberty] use TOLOWER instead of tolower " Joel Brobecker
2007-05-03 16:31                   ` Ian Lance Taylor
2007-05-03 23:40                     ` Joel Brobecker
2007-05-04  7:18                   ` Eli Zaretskii
2007-04-11  7:27       ` [RFA/libiberty] Fix documentation issues " Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070405172720.GB9281@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox