From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dj@redhat.com, gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Subject: Re: [RFA/libiberty] Enhance FILENAME_CMP for Windows filesystems
Date: Mon, 02 Apr 2007 07:01:00 -0000 [thread overview]
Message-ID: <20070402070228.GD3963@adacore.com> (raw)
In-Reply-To: <ubqi97hiq.fsf@gnu.org>
> Sorry for chiming in only now, but I have a few minor comments:
Not a problem at all, Eli. I am not able to followup on them right
now, but I promise I will in a few days.
> > for (;;)
> > {
> > int c1 = tolower (*s1);
> > int c2 = tolower (*s2);
>
> Are we sure that strncasecmp's behavior wrt to locales is identical to
> that of tolower's? If not, the above will introduce a bug in
> non-English locales.
For this question, I'm not sure, actually.
--
Joel
next prev parent reply other threads:[~2007-04-02 7:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-28 19:17 Joel Brobecker
2007-03-28 19:31 ` DJ Delorie
2007-03-28 19:36 ` Joel Brobecker
2007-03-28 20:23 ` Joel Brobecker
2007-03-28 20:44 ` DJ Delorie
2007-03-29 20:56 ` Joel Brobecker
2007-03-29 21:02 ` Joel Brobecker
2007-03-29 21:03 ` Daniel Jacobowitz
2007-03-29 21:07 ` DJ Delorie
2007-03-29 21:44 ` Joel Brobecker
2007-03-31 11:57 ` Eli Zaretskii
2007-03-31 22:40 ` Christopher Faylor
2007-04-01 3:04 ` Eli Zaretskii
2007-04-02 7:01 ` Joel Brobecker [this message]
2007-04-01 20:58 ` Andreas Schwab
2007-04-02 6:34 ` Joel Brobecker
2007-04-02 11:21 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070402070228.GD3963@adacore.com \
--to=brobecker@adacore.com \
--cc=dj@redhat.com \
--cc=eliz@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox