From: Andreas Schwab <schwab@suse.de>
To: Joel Brobecker <brobecker@adacore.com>
Cc: DJ Delorie <dj@redhat.com>,
gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Subject: Re: [RFA/libiberty] Enhance FILENAME_CMP for Windows filesystems
Date: Mon, 02 Apr 2007 11:21:00 -0000 [thread overview]
Message-ID: <je4pnz10or.fsf@sykes.suse.de> (raw)
In-Reply-To: <20070402063502.GB3963@adacore.com> (Joel Brobecker's message of "Sun, 1 Apr 2007 23:35:02 -0700")
Joel Brobecker <brobecker@adacore.com> writes:
>> > #ifdef HAVE_STRING_H
>> > #include <string.h>
>> > #endif
>>
>> That won't work without #include "config.h".
>
> Ah ha! Ben Elliston wrote me privately that he gets a warning
> on x86-linux (Ubunty) that strcmp.h is not defined. That would
> probably explain it. Thank you!
>
> Unfortunately, I'm going to be unavailable for the next two of three
> days. I'll try to fix it ASAP, but if someone could do this for me,
> I would really appreciate it.
I've checked this in.
Andreas.
2007-04-02 Andreas Schwab <schwab@suse.de>
* filename_cmp.c: Include "config.h".
--- libiberty/filename_cmp.c.~1.1.~ 2007-03-29 23:03:48.000000000 +0200
+++ libiberty/filename_cmp.c 2007-04-01 22:59:02.000000000 +0200
@@ -16,6 +16,10 @@
along with this program; if not, write to the Free Software Foundation,
Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. */
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
#ifdef HAVE_STRING_H
#include <string.h>
#endif
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, MaxfeldstraÃe 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
prev parent reply other threads:[~2007-04-02 11:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-28 19:17 Joel Brobecker
2007-03-28 19:31 ` DJ Delorie
2007-03-28 19:36 ` Joel Brobecker
2007-03-28 20:23 ` Joel Brobecker
2007-03-28 20:44 ` DJ Delorie
2007-03-29 20:56 ` Joel Brobecker
2007-03-29 21:02 ` Joel Brobecker
2007-03-29 21:03 ` Daniel Jacobowitz
2007-03-29 21:07 ` DJ Delorie
2007-03-29 21:44 ` Joel Brobecker
2007-03-31 11:57 ` Eli Zaretskii
2007-03-31 22:40 ` Christopher Faylor
2007-04-01 3:04 ` Eli Zaretskii
2007-04-02 7:01 ` Joel Brobecker
2007-04-01 20:58 ` Andreas Schwab
2007-04-02 6:34 ` Joel Brobecker
2007-04-02 11:21 ` Andreas Schwab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=je4pnz10or.fsf@sykes.suse.de \
--to=schwab@suse.de \
--cc=brobecker@adacore.com \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox